Fix cleanup revisited #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
2 times, most recently
from
1448519 to
1ce6aa3
Compare
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
from
1ce6aa3 to
5134854
Compare
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
from
5134854 to
de8c5a2
Compare
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
from
de8c5a2 to
e59a74b
Compare
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
from
e59a74b to
7038e27
Compare
notandy
reviewed
Dec 4, 2025
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
from
7038e27 to
344dedc
Compare
Delete all servers, and do not abort on the first failure.
The spec can disable the life-cycle or we can get a terminating condition, even while we are testing. We better clean up the test instances then too.
fwiesel
force-pushed
the
fix-cleanup-revisited
branch
2 times, most recently
from
a26dca8 to
2c19273
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
The log message was the same as in another delete case, and that makes it hard to identify where it gets deleted.
notandy
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.